Skip to content

FIX: fixed gamepad navigation in UI Toolkit TextField #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 10, 2025
Merged

FIX: fixed gamepad navigation in UI Toolkit TextField #2103

merged 14 commits into from
Feb 10, 2025

Conversation

@benoitalain
Copy link
Collaborator

@benoitalain benoitalain commented Jan 9, 2025

Description

Fixed UUM-77364: fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule.

Testing status & QA

Tested issue and fix manually. Modified unit test to include IsKeyboardNavigationEvent check.

Overall Product Risks

  • Complexity: medium
  • Halo Effect: low

Comments to reviewers

Requires prior landing of trunk PR: https://github.cds.internal.unity3d.com/unity/unity/pull/59210.

Asmdef define for UNITY_INPUT_SYSTEM_INPUT_MODULE_NON_KEYBOARD needs to be adjusted once that PR has landed.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@benoitalain benoitalain requested a review from bmalrat January 9, 2025 20:50
@benoitalain benoitalain changed the title Fixed UUM-77364. Requires trunk PR (same branch name). FIX: fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule Jan 10, 2025
@benoitalain benoitalain changed the title FIX: fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule FIX: fixed gamepad navigation in UI Toolkit TextField Jan 10, 2025
ekcoh
ekcoh approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ekcoh ekcoh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, thanks for addressing this.

ekcoh
ekcoh previously requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ekcoh ekcoh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it doesn't compile cleanly (CI failures) that needs to be looked into, maybe you are expected types that doesn't exist on older versions? Suspect this is why you added the new conditional symbol define. Also seem to have file conflict.

@benoitalain
Copy link
Collaborator Author

benoitalain commented Jan 17, 2025

Seems like it doesn't compile cleanly (CI failures) that needs to be looked into, maybe you are expected types that doesn't exist on older versions? Suspect this is why you added the new conditional symbol define. Also seem to have file conflict.

The corresponding trunk PR needs to land first. Also, I will adjust the asmdef define constraint when it has landed, since I can't know what it is for sure before that.

@benoitalain
Fixed Unity.InputSystem.asmdef Unity version after trunk PR landed.
853962e
@benoitalain
Making sure uGUI is the latest version.
ecf41d5
@benoitalain
Merge branch 'develop' of github.com:Unity-Technologies/InputSystem i…
ef4310b 
…nto uitech/bugfix/uum-77364-inputsysteminputmodulenonkeyboardnavigation

# Conflicts:
#	Packages/com.unity.inputsystem/CHANGELOG.md
#	Packages/manifest.json
@benoitalain benoitalain requested a review from ekcoh February 4, 2025 20:18
@benoitalain
Copy link
Collaborator Author

benoitalain commented Feb 4, 2025

Trunk PR https://github.cds.internal.unity3d.com/unity/unity/pull/59210 has just landed to 6000.2.0a4, making this PR now testable.

@benoitalain benoitalain dismissed ekcoh’s stale review February 7, 2025 21:05

Comment no longer applies. You're welcome to redo the review, but not much has been changed since your last one.

ekcoh
ekcoh approved these changes Feb 10, 2025
View reviewed changes
Packages/com.unity.inputsystem/CHANGELOG.md Outdated
### Fixed
- Fixed an issue where removing a newly created action in the Asset Editor would cause an exception. [UUM-95693](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-95693)
- Fixed arrow key navigation of Input Actions after Action rename. [ISXB-1024](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1024)
- Fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule.
Copy link
Collaborator

@ekcoh ekcoh Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There wasn't any public issue tracker on this?

Copy link
Collaborator Author

@benoitalain benoitalain Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I hadn't looked correctly, yes, let me quickly fix this!

This should be it: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77364

@benoitalain benoitalain merged commit 14bb2d5 into develop Feb 10, 2025
94 checks passed
@benoitalain benoitalain deleted the uitech/bugfix/uum-77364-inputsysteminputmodulenonkeyboardnavigation branch February 10, 2025 18:43
@benoitalain benoitalain mentioned this pull request Feb 19, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekcoh ekcoh ekcoh approved these changes

@Pauliusd01 Pauliusd01 Pauliusd01 approved these changes

@bmalrat bmalrat Awaiting requested review from bmalrat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benoitalain @ekcoh @Pauliusd01